(0.95.3) Restores open boundary condition functionality #3937
Conversation
|
shoudl we add a test to make sure it keeps working? |
|
a test is a good idea. |
| @@ -61,7 +61,7 @@ end | |||
|
|
|||
| const c = Center() | |||
|
|
|||
| @inline function _fill_west_open_halo!(j, k, grid, ϕ, bc::FEOBC, loc, clock, model_fields) | |||
| @inline function _fill_west_halo!(j, k, grid, ϕ, bc::FEOBC, loc, clock, model_fields) | |||
| Δx₁ = xspacing(1, j, k, grid, c, c, c) | |||
There was a problem hiding this comment.
| Δx₁ = xspacing(1, j, k, grid, c, c, c) | |
| Δx₁ = Δxᶜᶜᶜ(1, j, k, grid) |
Probably better to use the pointwise operators from here (and in the rest of this file)
navidcy
changed the title
jagoosw
changed the title
|
I might be missing something but I think that the changes in #3834 make it so that open halos are filled even when Edit: I have now added it |
| # Returns the boundary conditions a specific side for `FieldBoundaryConditions` inputs and | ||
| # a tuple of boundary conditions for `NTuple{N, <:FieldBoundaryConditions}` inputs | ||
| for dir in (:west, :east, :south, :north, :bottom, :top) | ||
| extract_side_bc = Symbol(:extract_, dir, :_bc) | ||
| @eval begin | ||
| @inline $extract_side_bc(bc) = bc.$dir | ||
| @inline $extract_side_bc(bc) = retrieve_bc(bc.$dir) |
There was a problem hiding this comment.
@simone-silvestri I think we need this analogously to retrieve_open_bc
jagoosw
added
bug 🐞
|
@glwagner @simone-silvestri I think this should be all done now and we should merge ASAP since open boundaries are currently broken |
tomchor
changed the title
|
Let's maybe try to release both this and #3606 together to avoid multiple patch releases. Both seem to be ready to merge. |
The refactoring in #3834 broke flat extrapolation open boundary conditions. This restores them.
Closes #3975